Don't use hardcoded package versions #7809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
requested review from
rainersigwald,
benvillalobos,
crummel and
MichaelSimons
rainersigwald
approved these changes
Jul 11, 2022
| @@ -25,13 +25,23 @@ | |||
| </PropertyGroup> | |||
| <!-- Production Dependencies --> | |||
| <PropertyGroup> | |||
| <SystemCollectionsImmutableVersion>6.0.0</SystemCollectionsImmutableVersion> | |||
There was a problem hiding this comment.
We weren't consistent about it before so no concerns about you not doing it but I moved these to the "Production Dependencies" group rather than "toolset" (except for the one that's actually toolset).
MichaelSimons
approved these changes
Jul 11, 2022
|
Thanks for the approvals, @rainersigwald please merge when appropriate as I don't have permissions. |
rainersigwald
added
the
merge-when-branch-open
crummel
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes # #7794
Changes Made
Move package versions to eng/Versions.props instead of being located directly in the PackageReferences in eng/Packages.props. This allows source-build to override some PackageReferences at build time if we need to.
Testing
I tested this using
./build.sh,./build.shwith the repo source-build configuration, and in a source-build tarball, all built fine.Notes
I attached the prebuilt report resulting from a source-build with changes from this PR and #7798
msbuild-7-11-22.txt