Remove unreachable and unused overload methods from IntrinsicFunctions #8649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue to be created)
Context
This is a change that was split out from PR #8569 at the request of @rainersigwald.
The change removes type overload methods from
IntrinsicFunctions
that are unreachable via evaluation and that are unused within the repo.This is cleanup that could support a future effort to add source generation for the 'fast path' lookup.
Changes Made
Remove
long
variants ofAdd
,Subtract
,Multiply
,Divide
, andModulo
. Evaluation will always use thedouble
variants.Testing
Built and ran unit tests on Windows 11 and macOS 12.
Notes