Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Providing-Binary-Logs.md #8690

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Update Providing-Binary-Logs.md #8690

merged 1 commit into from
Apr 23, 2023

Conversation

jaredpar
Copy link
Member

Need to include "" around the path in the Powershell case

@jaredpar
Update Providing-Binary-Logs.md
67a3c7c 
Need to include `""` around the path in the Powershell case
@rainersigwald
Copy link
Member

Test failure is ToolTaskThatTimeoutAndRetry which should hopefully be addressed by #8659. Retrying.

@jaredpar
Copy link
Member Author

Do we need a second reviewer here? The Merge button is still grayed out

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 21, 2023
@JaynieBai JaynieBai merged commit 10a1f7a into main Apr 23, 2023
@JaynieBai JaynieBai deleted the dev/jaredpar/docs branch April 23, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredpar @rainersigwald @JaynieBai