Emit relative path to output #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a short recording of what it looks like:
It does help a lot over using absolute paths! This is a reasonable sized terminal window (~1100x600) and it was still legible for this small, 7ish project repo. |
ladipro
requested changes
Apr 24, 2023
ladipro
approved these changes
Apr 24, 2023
src/MSBuild/LiveLogger/LiveLogger.cs
Outdated
|
|
||
| // If the output path is under the initial working directory, make the console output relative to that to save space. | ||
| if (outputPathSpan.StartsWith(_initialWorkingDirectory.AsSpan(), FileUtilities.PathComparison) | ||
| && (outputPathSpan[_initialWorkingDirectory.Length] == Path.DirectorySeparatorChar |
There was a problem hiding this comment.
It's not possible for outputPathSpan to be the same as _initialWorkingDirectory to cause a crash here, is it?
There was a problem hiding this comment.
Hm. Not normally, but we can't control what projects might emit, so we should definitely guard against this.
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A top comment from the folks who've seen this is that the absolute paths take up a bunch of space and making them relative would be a UX nicety. This is the simplest possible approach for that: string prefix truncation with no path comparison anything.