Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaskRegistry CPUWatson issues due to false optimistic concurrency #8861

Closed
wants to merge 10 commits into from
+123 −114
Closed

Fix TaskRegistry CPUWatson issues due to false optimistic concurrency #8861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3e01b5e
Make TaskRegistry.GetTaskRegistrationRecord and TaskRegistry.Register…
JanKrivanek Jun 8, 2023
b9bbf23
Makete TaskRegistry.CanTaskBeCreatedByFactory thread safe
JanKrivanek Jun 8, 2023
53b00ce
Make _cachedTaskRecordsWithExactMatch thread safe
JanKrivanek Jun 8, 2023
a88e70d
Make _cachedTaskRecordsWithFuzzyMatch threadsafe
JanKrivanek Jun 8, 2023
88343e1
Fix _cachedTaskRecordsWithExactMatch
JanKrivanek Jun 8, 2023
8c0891f
Add order agnostic dictionaries comparison
JanKrivanek Jun 9, 2023
3d36b54
Make TaskRegistry task ordering deterministic (FIFO)
JanKrivanek Jun 15, 2023
5ac71c3
Fix style
JanKrivanek Jun 15, 2023
e12bec2
Reflect PR suggestions
JanKrivanek Jun 16, 2023
aa21310
Fix nullref
JanKrivanek Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Build.UnitTests/TestComparers/TaskRegistryComparers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Collections;
using System.Collections.Generic;
using Microsoft.Build.Evaluation;
using Microsoft.Build.Execution;
Expand All @@ -28,7 +29,9 @@ public bool Equals(TaskRegistry x, TaskRegistry y)
{
Assert.Equal(xp.Key, yp.Key, TaskRegistry.RegisteredTaskIdentity.RegisteredTaskIdentityComparer.Exact);
Assert.Equal(xp.Value, yp.Value, new RegisteredTaskRecordComparer());
});
},
TaskRegistry.RegisteredTaskIdentity.RegisteredTaskIdentityComparer.Exact,
true);

return true;
}
Expand Down
Loading