-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binlog corruption with incorrectly serialized blob size. #9057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@filipnavara @dalexsoto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for getting to the bottom of it!
As a separate PR (no need to give Filip more work), I recommend that the MSBuild team adds a unit-test that would have caught this regression (unless it's hard for some reason). |
I expect to do it in this PR (but our team can do it--I'm not assigning Filip more work!)--because I expect that Tactics will ask the "do you have a regression test for this?" question when we take this tomorrow. |
Sorry for the inconvenience. I created PR with test targeting 17.7. In the meantime, you can use |
Superseded by #9065. Thanks for swift action. |
Contributes to fixing xamarin/xamarin-macios#18568
Context
PR #9022 introduced a bug which started incorrectly serializing blobs in .binlog format due to overlooked
long
vs.int
bug (https://github.com/dotnet/msbuild/pull/9022/files#r1271468212).Changes Made
Added a missing
int
cast to preserve the original .binlog file format.Testing
Manually tested that the .binlog is fixed and readable by MSBuildLog viewer after this change.
Notes