Stub tasks that are not supported on .NET #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a |
Did you mean |
Sure did! |
rainersigwald
approved these changes
Sep 27, 2023
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this pull request
Oct 16, 2023
Following the pattern used for the `ResolveComReference` task, create stubs for .NET that provide a clear error message indicating the task is not supported on .NET. Fixes dotnet#3499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3499
Context
Following the pattern used for the
ResolveComReferencetask, create stubs for .NET that provide a clear error message indicating the task is not supported on .NET.Changes Made
The following tasks have been updated:
ALAspNetCompilerGenerateBootstrapperGenerateTrustInfoGetFrameworkSdkPathRegisterAssemblyResolveComReferenceResolveNativeReferenceUnregisterAssemblyUpdateManifestWinMDExpAdditionally, the Utilities project has been updated so thatAppDomainIsolatedTask(base class ofAppDomainIsolatedTaskExtensionand a dependency ofResolveComReference) is included for '.NETFramework' only.Testing
Tested on macOS and Windows 11 with test project files (attached as TaskTest.zip.)
Notes
I don't have a full understanding of the interactions of the preprocessor symbols. (e.g. Is
FEATURE_APPDOMAINonly valid forNETFRAMEWORK?) There may be improvements that can be made to the conditionals in the source and in the .targets file.Should unit tests be added for the stubs?