-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update XmlPeek and XmlPoke tasks #9194
Merged
Merged
+90
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thanks!
maridematte
approved these changes
Oct 2, 2023
Created #9298 for an unreliable unit test that broke the Windows Core build. If someone with access can re-run the Windows Core build, I expect it will pass. |
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this pull request
Oct 16, 2023
Add `[Required]` to parameters. - `XmlPeek` Task - Change `Query` parameter. - Remove redundant `Dispose` that was flagged by the analyzer. - Change XmlPeek.XmlInput class from `Internal` to `private sealed` and change access of some members - Minor cleanup changes - `XmlPoke` Task - Change `Query` parameter. - Change `XmlInputPath` parameter. - Minor cleanup changes - XmlPeek_Tests class - Add new `PeekWithNoParameters` test - XmlPoke_Tests class - Remove `PokeMissingParams` test - The test was defined as a `[Fact]` and used a for loop to test 4 distinct cases - The test expected `ArgumentNullException` to be thrown - Add 4 new tests, one for each of the four cases: - `PokeWithNoParameters` - `PokeWithMissingRequiredQuery` - `PokeWithMissingRequiredXmlInputPath` - `PokeWithRequiredParameters` (completes the replacement of `PokeMissingParams` but might be a redundant test) Fixes dotnet#9140.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9140
Context
Add
[Required]
to parameters.Changes Made
XmlPeek
TaskQuery
parameter.Dispose
that was flagged by the analyzer.Internal
toprivate sealed
and change access of some membersXmlPoke
TaskQuery
parameter.XmlInputPath
parameter.PeekWithNoParameters
testPokeMissingParams
test[Fact]
and used a for loop to test 4 distinct casesArgumentNullException
to be thrownPokeWithNoParameters
PokeWithMissingRequiredQuery
PokeWithMissingRequiredXmlInputPath
PokeWithRequiredParameters
(completes the replacement ofPokeMissingParams
but might be a redundant test)Testing
Tested on macOS 12 and Windows 11.
Tested with the test project files shown in issue 9140.
Created and ran unit tests
Notes