-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branding to v17.9.0 #9252
Merged
YuliiaKovalova
merged 4 commits into
dotnet:main
from
YuliiaKovalova:dev/ykovalova/main_branding
Sep 25, 2023
Merged
Add branding to v17.9.0 #9252
YuliiaKovalova
merged 4 commits into
dotnet:main
from
YuliiaKovalova:dev/ykovalova/main_branding
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
force-pushed
the
dev/ykovalova/main_branding
branch
from
September 22, 2023 14:31
4df2fcf
to
63d474f
Compare
rainersigwald
approved these changes
Sep 22, 2023
@YuliiaKovalova I think the new errors about "unnecessary suppressions" are probably legit, can you fix those Monday? |
maridematte
approved these changes
Sep 25, 2023
used the solution provided here |
YuliiaKovalova
force-pushed
the
dev/ykovalova/main_branding
branch
from
September 25, 2023 11:20
a8c0ca2
to
a222f0e
Compare
@rainersigwald , could you double-check if the provided fix is correct? |
rainersigwald
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add branding to v17.9