Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding to v17.9.0 #9252

Merged

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Sep 22, 2023

Add branding to v17.9

@YuliiaKovalova YuliiaKovalova changed the title Add branding to v17.9 Add branding to v17.8.3 Sep 22, 2023
eng/Versions.props Outdated Show resolved Hide resolved
@YuliiaKovalova YuliiaKovalova force-pushed the dev/ykovalova/main_branding branch from 4df2fcf to 63d474f Compare September 22, 2023 14:31
@rainersigwald rainersigwald changed the title Add branding to v17.8.3 Add branding to v17.9.0 Sep 22, 2023
@rainersigwald
Copy link
Member

@YuliiaKovalova I think the new errors about "unnecessary suppressions" are probably legit, can you fix those Monday?

@YuliiaKovalova
Copy link
Member Author

@YuliiaKovalova I think the new errors about "unnecessary suppressions" are probably legit, can you fix those Monday?

used the solution provided here
dotnet/sdk#34936

@YuliiaKovalova YuliiaKovalova force-pushed the dev/ykovalova/main_branding branch from a8c0ca2 to a222f0e Compare September 25, 2023 11:20
@YuliiaKovalova
Copy link
Member Author

@rainersigwald , could you double-check if the provided fix is correct?

@YuliiaKovalova YuliiaKovalova merged commit 914c3e8 into dotnet:main Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants