Remove unnecessary quotes in loc strings #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
baronfel
approved these changes
Sep 27, 2023
YuliiaKovalova
approved these changes
Sep 27, 2023
I agree in principle but I think what caused the problem here was a comment? @cristianosuzuki77 do you know if there's something we can put in place here to prevent this sort of problem in the future? |
BTW I ignored this on purpose, and am managing flow of the resultant build so that it doesn't go anywhere. |
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this pull request
Oct 16, 2023
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These strings were introduced in #9217 but caused loc breaks.
Fixes #9283.
Customer Impact
Bad translations in non-English locales.
Regression?
No, new strings with bad contents.
Testing
N/A (build + XLF stuff passes)
Risk
None AFAIK--only risk is not getting new translations which we already aren't.