[ClickOnce] Update how ClickOnce chooses to publish items from the None group and…

[sujitnayak]

Fixes AB#1889893

Summary

Respect publish profile for items copied from transitive project references in ClickOnce.

Customer Impact

ClickOnce publish includes additional files irrespective of publish profile for .NET 5+ projects.

Regression?

Yes, new files are unconditionally published w.r.t. 17.7.

Testing

Validated the specific scenarios with sample Forms projects.Regression testing by CTI team.

Risk

Medium-low. The majority of the change is in ClickOnce-specific targets, but there's an item-name change that affects all projects. This to a “private” (initial-underscore-named) item and the change shouldn’t be observable outside the targets in question (the original item is still populated, just at a slightly later time).

Context

#9211
#9209

1. Above PRs added handling for ClickOnce publishing of items from the None group and content items from P2P references. However, it is publishing these items by default w/o checking if they have been opted in for publishing in the ClickOnce profile created in VS. Also the new behavior should only be applicable for apps targeting .NET>=5 and apps targeting .NET FX 4.X should not include these items for publishing at all.

2. The change does not consider the MSBuildCopyContentTransitive property which decides how transitive content is computed. Depending on the value of MSBuildCopyContentTransitive, the _RecursiveTargetForContentCopying property is set to the target that will compute the transitive content.

Changes Made

1. Items from the None group and content items from from P2P references that need to be published is now determined based on their presence in the PublishFiles collection and the extension of the files. This matches the logic used on the tooling side in VS. When items are opted into for publishing, they get added to the PublishFiles collection. DLL/EXE files are published by default.
   To exclude these items from being considered for ClickOnce publish, the PublishProcol property is also being checked. This property is not set during publish of .NET FX 4.X projects.

2. ClickOnce target is taking dependency on target set in the _RecursiveTargetForContentCopying property instead of GetCopyToOutputDirectoryItems directly. Setting of DeploymentComputeClickOnceManifestInfoDependsOn property is moved to a later point after the _RecursiveTargetForContentCopying value has been set.

Testing

Testing done with Forms apps with content items specific to the scenario described.
CTI has covered regression testing with these changes.

Notes

[sujitnayak]

I am changing the name from _TransitiveItemsToCopyToOutputDirectory to _CopyToOutputDirectoryTransitiveItems b/c otherwise _TransitiveItemsToCopyToOutputDirectory items are duplicated. They get added in this target and the caller then adds the returned items into the same item group.