Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a job for experimental Framework MSBuild insertion to a pipeline #9309

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

AR-May
Copy link
Member

@AR-May AR-May commented Oct 6, 2023

Context

We need to add an extra job to .exp-insertions.yml pipeline for creating experimental Framework MSBuild.

Changes Made

  • Pipeline refactored, a job added
  • Fixed bug in deploy script code path for Framework MSBuild

Testing

Manual run of the pipeline

@AR-May AR-May changed the title Add a job for experimental Framework MSBuild to a pipeline Add a job for experimental Framework MSBuild insertion to a pipeline Oct 6, 2023
@AR-May AR-May marked this pull request as ready for review October 6, 2023 13:02
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - I have just one comment for consideration

@rainersigwald
Copy link
Member

Could you link to the successful run, please?

@AR-May
Copy link
Member Author

AR-May commented Oct 11, 2023

Could you link to the successful run, please?

Sure, this link.

@AR-May AR-May requested a review from rainersigwald October 11, 2023 12:55
@AR-May AR-May merged commit c36a54e into dotnet:main Oct 12, 2023
bulatgrzegorz pushed a commit to bulatgrzegorz/selective-condition-evaluator that referenced this pull request Oct 16, 2023
…otnet#9309)

Context
We need to add an extra job to .exp-insertions.yml pipeline for creating experimental Framework MSBuild.

Changes Made
Pipeline refactored, a job added
Fixed bug in deploy script code path for Framework MSBuild
Testing
Manual run of the pipeline
MichalPavlik pushed a commit that referenced this pull request Oct 17, 2023
…9309)

Context
We need to add an extra job to .exp-insertions.yml pipeline for creating experimental Framework MSBuild.

Changes Made
Pipeline refactored, a job added
Fixed bug in deploy script code path for Framework MSBuild
Testing
Manual run of the pipeline
JaynieBai added a commit that referenced this pull request Oct 18, 2023
Fixes #1897030

Context
Checkout of CloudBuildConfig repo in Pipelines - Runs for MSBuild-prepare-exp-bits (azure.com) takes 10 minutes and we need only 1 file. We might research a solution to get this one file only (a web request with authorization maybe).
Add a job for experimental Framework MSBuild insertion to a pipeline #9309 (comment)
Changes Made
Use the https://learn.microsoft.com/en-us/rest/api/azure/devops/git/items/get?view=azure-devops-rest-4.1&tabs=HTTP
Filter the artifacts
Test
https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=8547869&view=results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants