Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policheck error #9311

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Fix policheck error #9311

merged 4 commits into from
Oct 10, 2023

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Oct 9, 2023

Fixes policheck:Error

Changes Made

  1. Skip the non en-us locale resource files.
  2. Skip the file that contains the specified entity names in the deprecated folder
  3. Change country to country/region based on https://policheck.microsoft.com/Pages/TermInfo.aspx?LCID=9&TermID=79570

Testing

Test with MSBuild pipeline build https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8509007&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=c5a86041-9185-53e8-42a2-1cadc4486f0d&l=5251. There are no active results now.

@JaynieBai JaynieBai marked this pull request as ready for review October 9, 2023 09:26
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Would you have more planned policheck fixes to go - it might be preferrable to bundle them all together

@JaynieBai
Copy link
Member Author

Looks good.

Would you have more planned policheck fixes to go - it might be preferrable to bundle them all together

No. This PR includes all the fixes of current policheck issues.

@JaynieBai JaynieBai merged commit 037f688 into main Oct 10, 2023
8 checks passed
@JaynieBai JaynieBai deleted the exp/FixPolicheckError branch October 10, 2023 06:05
bulatgrzegorz pushed a commit to bulatgrzegorz/selective-condition-evaluator that referenced this pull request Oct 16, 2023
Fixes policheck:Error

Changes Made

Skip the non en-us locale resource files.
Skip the file that contains the specified entity names in the deprecated folder
Change country to country/region based on https://policheck.microsoft.com/Pages/TermInfo.aspx?LCID=9&TermID=79570

Testing
Test with MSBuild pipeline build https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8509007&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=c5a86041-9185-53e8-42a2-1cadc4486f0d&l=5251. There are no active results now.
MichalPavlik pushed a commit that referenced this pull request Oct 17, 2023
Fixes policheck:Error

Changes Made

Skip the non en-us locale resource files.
Skip the file that contains the specified entity names in the deprecated folder
Change country to country/region based on https://policheck.microsoft.com/Pages/TermInfo.aspx?LCID=9&TermID=79570

Testing
Test with MSBuild pipeline build https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8509007&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=c5a86041-9185-53e8-42a2-1cadc4486f0d&l=5251. There are no active results now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants