Setup UnGAC: treat 259 as success #9325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
force-pushed
the
robustify-ungac
branch
from
711e23e to
4d214ff
Compare
One of the top VS Setup failures is a 259 from our UnGAC, even though we have a big try/catch that should make it never fail. Tell the Setup engine that 259 is another kind of success to keep this nonblocking. Fixes AB#1899796. Co-authored-by: Matt Cavallari <mjcavallari-zz@users.noreply.github.com>
rainersigwald
force-pushed
the
robustify-ungac
branch
from
4d214ff to
39faa48
Compare
ladipro
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Assuming this 259 is STILL_RUNNING and the installer kills such a hanging process, I wonder if we shouldn't implement a time limit in our code also. The amount of time the installer is willing to wait may still be unreasonably long and the user experience degraded.
JanKrivanek
reviewed
Oct 18, 2023
JanKrivanek
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the top VS Setup failures is a 259 from our UnGAC,
even though we have a big try/catch that should make it
never fail. Tell the Setup engine that 259 is another
kind of success to keep this nonblocking.
Fixes AB#1899796.