Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Cache docs to reflect new functionality #9329

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Oct 13, 2023

Update Project Cache docs to reflect new functionality

Most the new stuff was added in #9214, but some other changes have gone in before then as well which made these docs out of date.

documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's great to have this documented in detail and with samples!

The document delivers all the necessary info - in some minor cases it could have been more clear and/or less redundant. But those are rather minor things - even as is now, it is great value added.

documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor tweak suggestions but looks great to me, thanks and sorry for the review delay!

documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
documentation/specs/project-cache.md Outdated Show resolved Hide resolved
dfederm and others added 5 commits December 20, 2023 13:22
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@JanKrivanek JanKrivanek enabled auto-merge (squash) January 3, 2024 10:58
@JanKrivanek JanKrivanek merged commit b860fe5 into dotnet:main Jan 3, 2024
8 checks passed
@dfederm dfederm deleted the project-cache-docs branch January 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants