Stop touching GenerateBindingRedirects output #9338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0aa8c5f changed the behavior of `GenerateBindingRedirects` to always touch its output file, to prevent false-negative up-to-date checks on subsequent incremental builds. However, this causes breaks in customer scenarios: 1. Build, generate a `.exe.config` and copy it to the output directory. 2. Run the app, do some operation that modifies the .exe.config. 3. Make some change and rebuild the app. The .exe.config in the output directory is overwritten with the "fresh" copy generated by this run. A long-term fix is tracked by #9337 but for the short term we can revert to the pre-17.7 behavior.
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
maridematte
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item (Internal use): AB#1875355
Summary
Revert a behavior change in
GenerateBindingRedirectsthat results in overwritingapp-under-development.exe.configin situations where we didn't before 17.7, causing dev suprise.Customer Impact
Broken inner build loop because customizations stored in .exe.config file
Regression?
Yes, in 17.7. Introduced in 0aa8c5f.
Testing
Manual testing of repro scenario, automated tests.
Risk
Low. Reverts to previous behavior in a .NET Framework-only codepath.