Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtendedCriticalBuildMessageEventArgs and related tests #9363

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

rokonec
Copy link
Member

@rokonec rokonec commented Oct 26, 2023

Fixes #9355

Context

During 1st phase of creating Extended events we I have missed CriticalBuildMessageEventArgs

Changes Made

ExtendedCriticalBuildMessageEventArgs
Related unit tests

Testing

Local
Uni tests

Notes

This change does not break logviewer - tested - however another small PR in log viewer will be done to better support it.
Old log viewer:
image
Future log viewer:
image

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokonec rokonec merged commit d3fa669 into dotnet:main Oct 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BinFmt] Add build-in 'ExtendedCriticalBuildMessageEventArgs'
3 participants