-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exec: use C instead of en_US.UTF-8 to set the Exec locale. #9391
Conversation
The en_US locale can't be used on systems where it is not installed. This is common in container images. On such systems, setting the locale to en_US.UTF-8 causes unexpected warnings to be written to standard error. When Exec.LogStandardErrorAsError is set, these warnings cause the Task to fail due to logging errors. This changes to use the 'Computer English' C.UTF-8 locale, which is always available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks.
This was not meant to be merged yet, as we were still discussing the options in #4194. I should have made it more apparent in this PR. Based on the discussion there, leaving out the
@rainersigwald @wfurt @janvorli @danmoseley @KalleOlaviNiemitalo if it is good for you, I think we can keep this and see what feedback we get during the .NET 9 development. |
Our |
The en_US locale can't be used on systems where it is not installed. This is common in container images.
On such systems, setting the locale to en_US.UTF-8 causes unexpected warnings to be written to standard error.
When Exec.LogStandardErrorAsError is set, these warnings cause the Task to fail due to logging errors.
This changes to use the 'Computer English' C.UTF-8 locale, which is always available.
Fixes #4194
@rainersigwald @wfurt @janvorli ptal
cc @mthalman @omajid