-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missed errors appearance on restore #9424
Fix missed errors appearance on restore #9424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments inline. Additionally I'd like to ask if adding this logic to ErrorRaised
but not to WarningRaised
is intentional. Even if restore didn't produce any warnings, I feel like we should behave consistently between the two for future-proofing.
I was discussing this implementation with @rainersigwald, but probably I didn't get him right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ladipro: the same logic for errors should apply to warnings. We shouldn't ever fail to log a warning or error just because it happened at a time where we weren't fully expecting it.
Oh and please add a Verify test of a project that fails during Restore. |
Fixes #9082
Context
Errors can be missed from the output if these are not associated with the tracked projects.
But this category of messages must be reported to the customers in any case.
Changes Made
Display non-associated errors.
Testing
Manual
Notes