Don't expose VisualStudio.Setup to NuGet #9430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
LGTM. CPM also offers Global Package References in case that's helpful for you: https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#global-package-references
In the switch to Central Package Management (dotnet#8317), I missed that PrivateAssets doesn't apply to PackageVersion items, which caused us to have an extraneous dependency from some of our packages to `Microsoft.VisualStudio.Setup.Configuration.Interop` for 17.6, 17.7, and 17.8.
rainersigwald
force-pushed
the
drop-interop-ref
branch
from
5addea0 to
dfaaa9c
Compare
|
Yeah I contemplating switching this one, but decided (as I think we did before) that we don't use it in enough of the projects. Would have avoided this problem though! |
rainersigwald
added
the
Area: Our Own Build
JanKrivanek
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the switch to Central Package Management (#8317), I missed that PrivateAssets doesn't apply to PackageVersion items, which caused us to have an extraneous dependency from some of our packages to
Microsoft.VisualStudio.Setup.Configuration.Interopfor 17.6, 17.7, and 17.8.