Exit the loop after finding the switch name in the map #9453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 24, 2023 11:51
rainersigwald
approved these changes
Dec 4, 2023
ladipro
approved these changes
Dec 5, 2023
|
Closing PR with to merge it to vs17.9: #9493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The methods: IsParameterlessSwitch and IsParameterizedSwitch are desgined to identify if the switch is exist or not, iterates the switches map and assignes the found values to the output variables, however after finding the needed parameter (name comparison) it continues to search till the end of the map, which makes it unnecessary since the name is unique across the all presented switches
Changes Made
Exit the method as soon the parameter name is find and the values are assigned.
Testing
Existing tests should pass