Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VersionOverride to XSD for PackageReference elements #9473

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Nov 29, 2023

Fixes VS feedback ticket https://developercommunity.visualstudio.com/t/Code-Completion-for-Nuget-Package-Refere/10525616

Context

NuGet's Central Package Management (CPM) allows users to specify package versions in a central location. However, sometimes you may need to override the centrally defined version for a particular package so you specify the VersionOverride attribute documented here.

Changes Made

Added VersionOverride to the XSD for auto-completion in Visual Studio.

Testing

Unsure how to test this.

Notes

@jeffkl jeffkl self-assigned this Nov 29, 2023
@rainersigwald rainersigwald added the Area: IntelliSense Issues with the XSD-schema driven code completion experience for MSBuild in Visual Studio. label Nov 29, 2023
@AR-May
Copy link
Member

AR-May commented Dec 6, 2023

I think we should target vs17.9 branch for this PR, since this is not considered a new feature but rather a bug?

@jeffkl jeffkl changed the base branch from main to vs17.9 December 12, 2023 18:59
@jeffkl
Copy link
Contributor Author

jeffkl commented Dec 12, 2023

I think we should target vs17.9 branch for this PR, since this is not considered a new feature but rather a bug?

I have changed the target branch, please merge when ready as I don't have permissions.

@rainersigwald rainersigwald enabled auto-merge (squash) December 12, 2023 19:12
@rainersigwald rainersigwald merged commit b2016b8 into dotnet:vs17.9 Dec 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IntelliSense Issues with the XSD-schema driven code completion experience for MSBuild in Visual Studio.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants