Сhange ProperyReassignment logged message type #9494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please retarget this PR to vs17.9 branch, since this is a bug fix. |
JanKrivanek
approved these changes
Dec 6, 2023
| [Fact] | ||
| public void VerifyLogPropertyReassignment() | ||
| { | ||
| string testtargets = ObjectModelHelpers.CleanupFileContents(@" |
There was a problem hiding this comment.
NIT: using """ literals allows you to use quotations as is without need to escape
KirillOsenkov
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Looks great!
I built bootstrap MSBuild from this branch, built a project, opened in binlog viewer, and it all looks good. Confirmed the code path in the viewer to synthesize these is no longer taken. Confirmed you can search for Property reassignment, new values and old values are displayed correctly, you can navigate to the location.
Also in File -> Statistics you can see that it's usually the 6th most used args type:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9385
Context
During the Evaluation phase, property reassignment was logged as a plain message.
Changes Made
convert plain message to -> PropertyReassignmentEventArgs
Testing
UT is added