Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.9] Formatting changes to prevent unnoticed version merges into main #9661

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

JanKrivanek
Copy link
Member

Context

We intentionally have DotNetFinalVersionKind on aa same line as VersionPrefix so that codeflow to main causes conflict that needs to be manually resolved and hence we do not end up with unnoticed uninteded version prefix revert in main due to merged codeflow.

Recent arcade update reformatted our Version.props: #9574 - so fixing it back

@JanKrivanek JanKrivanek requested a review from a team as a code owner January 18, 2024 09:19
@ghost
Copy link

ghost commented Jan 18, 2024

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@JanKrivanek JanKrivanek changed the title Formatting changes to prevent unnoticed version merges into main [17.9] Formatting changes to prevent unnoticed version merges into main Jan 18, 2024
@JanKrivanek JanKrivanek enabled auto-merge January 18, 2024 09:23
@JanKrivanek JanKrivanek merged commit 90725d0 into vs17.9 Jan 18, 2024
8 checks passed
@JanKrivanek JanKrivanek deleted the JanKrivanek-patch-4 branch January 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants