Respect response files (ignoreProjectExtensions) property #9677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Jan 24, 2024
JanKrivanek
approved these changes
Jan 29, 2024
rainersigwald
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9507
Context
The ignoreProjectExtensions are not respected if specidified in response file on project level.
The exception will be thrown in case there are ambiguous files identified in provided directory. Example:
Directiory contains:
The build fails since there are multiple files identified to build.
IgnoreProjectExtensions: .sln solves the situation but when specified in response file on project level the error will raise before the usage of the response file.
Changes Made
Identifying projectFile was extracted from CheckAndGatherProjectAutoResponseFile, and moved to ProcessCommandLineSwitches.
Testing
Added specific to the case test case
All existing tests should pass