Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseArtifactsOutput and ArtifactsPath to XSD #9681

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

GangWang01
Copy link
Member

Fixes #9676

Context

Autocomplete list when editing a Directory.Build.props file in VS doesn't include the properties UseArtifactsOutput and ArtifactsPath.

Changes Made

Add the properties to XSD file for the autocomplete list.

Testing

N/A

Notes

@GangWang01 GangWang01 marked this pull request as ready for review January 25, 2024 10:08
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions, now that I know the URLs can be included.

src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
Copy link
Member

@rokonec rokonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@GangWang01 GangWang01 merged commit 97651a2 into dotnet:main Jan 31, 2024
8 checks passed
@GangWang01 GangWang01 deleted the artifacts-intellisense branch January 31, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseArtifactsOutput and ArtifactsPath properties are missing from autocomplete list
3 participants