Changes to enable building msbuild with Unified Build #9685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables building msbuild from within the VMR in non source-only modes. - Split dependency properties for net framework targets to maintain VS compat. - Disable building type libraries when building on Core, and looking to package them up. - Bootstrap build should look for DotNetRoot, not RepoRoot. This will correctly pick up the global SDK from the VMR. - Exclude a couple projects that are VS specific and cause issues (typically packaging TLBs) - Don't look to copy net3.5 targeted PDBs when building on Core.
mmitche
commented
Jan 26, 2024
Don't attempt to copy the PDBs at all when building on core on non-windows platforms.
|
Confirmed on Linux and Windows, |
JanKrivanek
approved these changes
Jan 27, 2024
ViktorHofer
reviewed
Jan 29, 2024
ViktorHofer
reviewed
Jan 29, 2024
|
@JanKrivanek @ViktorHofer I've changed the logic to not override the TFMs in normal UB modes. |
rainersigwald
approved these changes
Jan 30, 2024
ViktorHofer
reviewed
Jan 31, 2024
ViktorHofer
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables building msbuild from within the VMR in non source-only modes.