-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve msbuild logger for testing workloads #9706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rainersigwald aren't we working on removing the project prefix for each error report or something? |
nohwnd
commented
Feb 8, 2024
@baronfel @rainersigwald @rokonec I am close to happy. Would love to know if I need to change something significantly. |
This was referenced Feb 14, 2024
nohwnd
commented
Feb 16, 2024
nohwnd
commented
Feb 16, 2024
nohwnd
commented
Feb 16, 2024
MichalPavlik
approved these changes
Feb 16, 2024
rokonec
approved these changes
Feb 19, 2024
Available in dotnet/installer since 9.0.100-preview.2.24121.2 if anyone wants to try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vstest#4843
Needs microsoft/vstest#4877 to work, but does not break without it.
Context
Terminal logger is reporting build, but when tests run via MSBuild there is very little feedback about what is going on.
Changes Made
Adds colored test results where targets are normally.
Writes summary for tests after the test run.
Writes result for every test projects, no matter if it fails or succeeds.
Testing
yup.
Notes
In comments.