Revert changes for "ResultsCache ignores some of the BuildRequest dat… #9718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-alizada
approved these changes
Feb 8, 2024
|
FYI, this also seemed to be causing some issues when using differing versions of MSBuild: Currently this repros when importing results in 17.10 from a file produced with 17.9. The issue does not repro when the consuming (2nd) build is using IntPreview (nor GA), so I'm guessing this revert mitigates the issue. I didn't look too deeply, but my guess is that the problem is that a field was added to |
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Apr 10, 2024
…uest data,.." (dotnet#9718)" This reverts commit 553649b.
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Apr 10, 2024
…uest data,.." (dotnet#9718)" This reverts commit 553649b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The changes #9565 seem to cause regression Bug 1943607 in Azure dev ops.
Revert changes to unblock the customers and get back to it later.