Use invariant culture for converting propertie's values to string #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Mar 17, 2024
f-alizada
changed the title
f-alizada
changed the title
rainersigwald
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9757
Context
The evaluation of the project is affected in case:
The resulting values of the properties is a negative number and the Culture the parsing used contains different unicode for a minus sign and later used in arithmetic condition results failed project exception.
Due to the converting numeric type ToString using current Culture (or not specifying to convert using InvariantCulture) and later using the InvariantCulture for trying to parse the saved .
msbuild/src/Shared/ConversionUtilities.cs
Line 185 in 00833d9
Changes Made
Check if the object is a numeric type then convert it to string using InvariantCulture. ChangeWave 17.10
Testing
Added tests to replicate the behavior with/without changewave.