Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added task assembly location to TaskStartedEventArgs #9948

Merged
merged 20 commits into from
Apr 19, 2024
Merged

Added task assembly location to TaskStartedEventArgs #9948

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1c2f95f
Added task assembly name to TaskStartedEventArgs
MichalPavlik Mar 28, 2024
c5c6e34
AssemblyName was removed in favor of simple string
MichalPavlik Apr 3, 2024
5b597b5
Removed ITaskExecutionHost
MichalPavlik Apr 3, 2024
36bc3d8
Extended serialization test
MichalPavlik Apr 3, 2024
92e2de4
Removed FindTaskAssemblyName and incremented binlog version.
MichalPavlik Apr 4, 2024
784fafe
Minor refactoring. Leaving the place in better condition:)
MichalPavlik Apr 4, 2024
ca16fd8
Use FullName instead of Name
MichalPavlik Apr 4, 2024
aa645e1
Additional extended test
MichalPavlik Apr 4, 2024
9cba8a3
Removed unnecessary code
MichalPavlik Apr 5, 2024
0c09b10
Resolving comments
MichalPavlik Apr 8, 2024
cfecf42
Logging assembly location instead of assembly full name
MichalPavlik Apr 8, 2024
6153122
Minor refactoring
MichalPavlik Apr 8, 2024
6f31301
Removed unnecessary usings
MichalPavlik Apr 8, 2024
4c4ccc4
Emitting message when expected task assembly location does not match …
MichalPavlik Apr 8, 2024
21055db
Resolving comments
MichalPavlik Apr 9, 2024
39be7ea
Reverted unwanted changes in resource file
MichalPavlik Apr 10, 2024
8d416f7
Exclude in-memory assemblies from location mismatch check
MichalPavlik Apr 11, 2024
b185844
Resolving comment
MichalPavlik Apr 16, 2024
53f310a
Changed the mismatch message
MichalPavlik Apr 16, 2024
f0dd324
Updated xlfs
MichalPavlik Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Build/BackEnd/TaskExecutionHost/TaskExecutionHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ public bool InitializeForBatch(TaskLoggingContext loggingContext, ItemBucket bat
return false;
}

if (TaskInstance.GetType().Assembly.Location != _taskFactoryWrapper.TaskFactoryLoadedType.Path)
if (!string.IsNullOrWhiteSpace(TaskInstance.GetType().Assembly.Location) &&
TaskInstance.GetType().Assembly.Location != _taskFactoryWrapper.TaskFactoryLoadedType.Path)
MichalPavlik marked this conversation as resolved.
Show resolved Hide resolved
{
_taskLoggingContext.LogComment(MessageImportance.Normal, "TaskAssemblyLocationMismatch", TaskInstance.GetType().Assembly.Location, _taskFactoryWrapper.TaskFactoryLoadedType.Path);
}
Expand Down