Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle solution traversal targets in graph builds #9985

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Apr 9, 2024

Fixes #9952

This change adds understanding of "solution traversal" targets to graph builds. The special targets are like "ProjectName" or "ProjectName:TargetName" and can be used to build specific projects in a sln or specific targets on specific projects in a sln.

Also added some missing UTs for SolutionProjectGenerator to help my understanding for how these kinds of targets work.

@dfederm dfederm force-pushed the fix-graph-sln-traversal-targets branch from 26e96b5 to aa7e3ae Compare April 9, 2024 22:54
@AR-May AR-May requested review from JanKrivanek and f-alizada April 16, 2024 14:04
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

I just was confused about /t:ProjectName:Build - why is that not supported?

src/Build/Graph/ProjectGraph.cs Outdated Show resolved Hide resolved
src/Build/Graph/ProjectGraph.cs Show resolved Hide resolved
src/Build/Graph/ProjectGraph.cs Outdated Show resolved Hide resolved
@JanKrivanek JanKrivanek merged commit c1c863e into dotnet:main Apr 19, 2024
9 checks passed
@dfederm dfederm deleted the fix-graph-sln-traversal-targets branch April 25, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sln-based graph builds don't support the special targets with project names
3 participants