Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

add ARM64 pipeline #100

Merged
merged 2 commits into from
Aug 9, 2022
Merged

add ARM64 pipeline #100

merged 2 commits into from
Aug 9, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 8, 2022

This adds ARM64 build using X86 machine.
This PR is still little bit messy for time reasons. Some of the dependencies we can add to base images and remove extra steps. I also cloned make-packages.sh from msquic so I can update without waiting for PRs in msquic and PR to suck in changes. I will clean that up after we have ARM tests running.

This also includes some long needed cleanup in System.Net.MsQuic.Transport.csproj'. We would always try to build x64 and x86 - even if that is useless for macOS and Linux. (and does not work). It also ignored Configuration- creating release binaries in all cases. This now properly respectsConfiguration` from pipeline opening path to running stress and tests with debug build of msquic -> to get extra asserts and validation. (not part of this change)

wfurt added 2 commits August 8, 2022 10:17
@wfurt
Squashed commit of the following:
a628498 
commit d362536
Author: wfurt <tweinfurt@yahoo.com>
Date:   Sat Aug 6 13:34:53 2022 -0700

    fix configuration

commit a1bc833
Author: wfurt <tweinfurt@yahoo.com>
Date:   Sat Aug 6 12:50:32 2022 -0700

    buildargs

commit 196a686
Author: wfurt <tweinfurt@yahoo.com>
Date:   Sat Aug 6 12:42:39 2022 -0700

    _BuildConfig

commit 23b8102
Author: wfurt <tweinfurt@yahoo.com>
Date:   Sat Aug 6 11:38:43 2022 -0700

    parallel!

commit 174b6c5
Author: wfurt <tweinfurt@yahoo.com>
Date:   Sat Aug 6 00:41:22 2022 -0700

    parallel?

commit 4b4ca46
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 23:51:32 2022 -0700

    PKGARCH

commit 27b7768
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 23:02:37 2022 -0700

    fix path

commit 21535e7
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 22:37:30 2022 -0700

    make-packages

commit becaa70
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 21:17:03 2022 -0700

    IgnoreStandardErrorWarningFormat

commit b8022cc
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 20:51:42 2022 -0700

    parallel 1

commit 6517539
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 20:45:04 2022 -0700

    parallel 1

commit 52e3128
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 19:57:56 2022 -0700

    extraargs

commit ecbb187
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 19:34:40 2022 -0700

    _buildargs

commit a2eaf41
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 19:02:29 2022 -0700

    lltng

commit 601bb78
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 18:37:50 2022 -0700

    disable parallel build

commit 0403b37
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 18:13:15 2022 -0700

    fix quote

commit 381686f
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 18:01:41 2022 -0700

    updates

commit 1aba364
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 17:24:42 2022 -0700

    fix TargetArchitecture

commit c6bfad6
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 15:22:20 2022 -0700

    update msquic

commit f131fb8
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 12:30:44 2022 -0700

    fix arch

commit 535733a
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 11:56:28 2022 -0700

    pass arch

commit f412d86
Merge: 7c4ad53 6878aec
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 11:08:53 2022 -0700

    Merge branch 'main' of https://github.com/dotnet/msquic into armPipe2

commit 7c4ad53
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 11:08:05 2022 -0700

    buildargs

commit d57b39c
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 00:37:09 2022 -0700

    cmake

commit 274d295
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 00:20:06 2022 -0700

    curl

commit 694b7ea
Author: wfurt <tweinfurt@yahoo.com>
Date:   Fri Aug 5 00:11:23 2022 -0700

    echo

commit 5c7034f
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 23:53:59 2022 -0700

    fix tar

commit c91a236
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 23:35:27 2022 -0700

    pwsh

commit fe864a6
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 22:53:49 2022 -0700

    sudo

commit 7fcce5c
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 22:43:37 2022 -0700

    add ruby-dev

commit d4f1e4a
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 22:34:11 2022 -0700

    add ryby-dev

commit ed82670
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 22:23:58 2022 -0700

    fix sed

commit 7b15470
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 22:12:50 2022 -0700

    skip cmake

commit 8412dd4
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 21:58:49 2022 -0700

    update

commit 9c24a90
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 21:44:53 2022 -0700

    update

commit 2b3b6e6
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 21:35:08 2022 -0700

    update

commit 51a440a
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 21:12:16 2022 -0700

    add wget

commit 637b7a9
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 21:02:04 2022 -0700

    add wget

commit 85fbfad
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 20:40:23 2022 -0700

    add wget

commit 5bafe4c
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 20:32:12 2022 -0700

    add wget

commit 8e67acd
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 20:20:20 2022 -0700

    add wget

commit cc1c774
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:54:40 2022 -0700

    qemu-user-static

commit f8ea9fd
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:45:10 2022 -0700

    add debug

commit 62c4c5f
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:31:29 2022 -0700

    add debug

commit 3ce73e8
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:21:31 2022 -0700

    update path

commit 633f98f
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:18:27 2022 -0700

    update path

commit 9661bc0
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 18:05:33 2022 -0700

    not interactive

commit aeeeea9
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 17:56:15 2022 -0700

    update variable

commit 3fc517a
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 17:45:10 2022 -0700

    update variable

commit f2ff10b
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 17:03:59 2022 -0700

    update variable

commit b4bdaad
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:51:15 2022 -0700

    update variable

commit f227ac9
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:49:46 2022 -0700

    update variable

commit 6c29fdf
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:48:33 2022 -0700

    update variable

commit 4708c81
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:43:40 2022 -0700

    update docker

commit f4f0c6b
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:38:20 2022 -0700

    docker

commit ff4eee5
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:25:37 2022 -0700

    use -y

commit 4ab4205
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:18:02 2022 -0700

    use sudo

commit ea62c7a
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 16:09:53 2022 -0700

    use demands

commit 66f131b
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 15:46:47 2022 -0700

    roll-back to 1es-ubuntu-2004

commit 7e6cca4
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 14:54:00 2022 -0700

    updates

commit b691adb
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 13:59:50 2022 -0700

    update names

commit 0d7ff40
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 13:39:01 2022 -0700

    simplify

commit 384414b
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 13:37:02 2022 -0700

    fix name

commit 6773c6f
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 13:27:02 2022 -0700

    remove line

commit b34ddcb
Author: wfurt <tweinfurt@yahoo.com>
Date:   Thu Aug 4 11:19:13 2022 -0700

    use Build.Ubuntu.2004.x64

commit f785f60
Author: wfurt <tweinfurt@yahoo.com>
Date:   Wed Aug 3 15:45:25 2022 -0700

    try to add ARM pipeline
@wfurt
remove unused variable
23958e4
@wfurt wfurt requested review from karelz, MattGal, ManickaP and rzikm August 8, 2022 17:25
rzikm
rzikm reviewed Aug 9, 2022
View reviewed changes
eng/pipelines/templates/build-job.yml
# use cmake from Brew (that may be different)
- script: sed -i .ORI '/cmake/d' global.json
- script: sed -i.ORI '/cmake/d' global.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the space removal intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. The old version fails on Linux

furt@ubu18:~$ sed -i .ORI '/cmake/d'  global.json
sed: -e expression #1, char 1: unknown command: `.'

Without the space it works on both &macOS & Linux

@wfurt wfurt merged commit 2d9b047 into main Aug 9, 2022
@wfurt wfurt mentioned this pull request Aug 25, 2022
Closed
@wfurt wfurt deleted the arm64 branch September 6, 2022 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzikm rzikm rzikm approved these changes

@karelz karelz Awaiting requested review from karelz

@MattGal MattGal Awaiting requested review from MattGal

@ManickaP ManickaP Awaiting requested review from ManickaP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfurt @rzikm