You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
fsproj need to call netcoreapp fsc, and is doing that with /path/to/dotnet.exe /path/to/fsc
Atm doesnt exists a property from msbuild/sdk who give dotnet path, ref #75 (comment)
When called from .NET Core sdk (dotnet msbuild) or mono (after #75) the path of dotnet location is relative to $(MSBuildSDKsPath) because works ok for mono/netcore.
But is not enough for msbuild (.net full) installed by VS, and sdk path is %PROGRAMFILES(X86)%\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\
Proposed solution is just dotnet, resolved from PATH (only for win/netfull atm based on $(MSBuildRuntimeType) ) so will use global.json if the installed dotnet is the one in PATH.
That's because i cannot find a relative path who can work.
Maybe make mandatory this solution for everyone (mono/netcoresdk) can be ok too. less corner cases.
But will make dotnet resolution fragile, so running my/binaries/but/not/in/PATH/dotnet.exe fsproj may use a wrong dotnet (ref bug #65). so tradeoff
fsproj need to call netcoreapp
fsc
, and is doing that with/path/to/dotnet.exe /path/to/fsc
Atm doesnt exists a property from msbuild/sdk who give
dotnet
path, ref #75 (comment)When called from .NET Core sdk (
dotnet msbuild
) or mono (after #75) the path of dotnet location is relative to$(MSBuildSDKsPath)
because works ok for mono/netcore.But is not enough for msbuild (.net full) installed by VS, and sdk path is
%PROGRAMFILES(X86)%\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\
Proposed solution is just
dotnet
, resolved fromPATH
(only for win/netfull atm based on$(MSBuildRuntimeType)
) so will useglobal.json
if the installed dotnet is the one inPATH
.That's because i cannot find a relative path who can work.
Maybe make mandatory this solution for everyone (mono/netcoresdk) can be ok too. less corner cases.
But will make
dotnet
resolution fragile, so runningmy/binaries/but/not/in/PATH/dotnet.exe fsproj
may use a wrong dotnet (ref bug #65). so tradeoffAny ideas for VS? just use global.json and
PATH
? @eerhardt @rainersigwald @jeffkl @nguerrera @dsplaisted @piotrpMSFT/cc @KevinRansom @cartermp @vasily-kirichenko
The text was updated successfully, but these errors were encountered: