Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should apply year label instead of month label in 10-years chart #189

Open
tonyqus opened this issue Jan 22, 2022 · 6 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tonyqus
Copy link
Contributor

tonyqus commented Jan 22, 2022

image

Two problems

  • There is no explicit year shown in the x-axis labels
  • Yearly label should be used instead of monthly
@bruno-garcia bruno-garcia added the enhancement New feature or request label Jan 27, 2022
@bruno-garcia
Copy link
Member

Makes sense

@joaopgrassi
Copy link
Member

joaopgrassi commented Feb 3, 2022

This should be a good first issue. @tonyqus do you want to give it a try? 😊

@tonyqus
Copy link
Contributor Author

tonyqus commented Feb 3, 2022

Not always me. It's still your project. I understand that you may be busy in your real job. But if PMC gives up the project, no one can rescue it.

@joaopgrassi
Copy link
Member

I only asked if you were interested in taking the issue because you seemed like wanting to get involved with the project and it's a small one and would greatly fix a user-facing "bug", while giving a good idea of how things work. Sorry if I misread things.

As for the rest of the comments, not sure but nobody is abandoning anything here 😊. @bruno-garcia and I are the maintainers, but anyone can fix/propose/enhance anything.

I only asked if you were interested so I could assign the issue to you.

@joaopgrassi joaopgrassi added the good first issue Good for newcomers label Feb 14, 2022
@fontanaricardo
Copy link

What do you think about this scales?

  • 3 to 6 months: week;
  • 1 to 2 years: month-year;
  • 6 to 10 years: year.

@bruno-garcia
Copy link
Member

What do you think about this scales?

  • 3 to 6 months: week;
  • 1 to 2 years: month-year;
  • 6 to 10 years: year.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants