Distributed Tracing: Use recommended conventions for setting status a…

…nd stack traces
dotnet · Feb 19, 2024 · f949e90 · f949e90
1 parent f043afa
commit f949e90
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs b/src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs
@@ -51,19 +51,24 @@ protected static async Task Process(IGrainCallContext context, Activity activity
                 await context.Invoke();
                 if (activity is not null && activity.IsAllDataRequested)
                 {
-                    activity.SetTag("status", "Ok");
+                    activity.SetStatus(ActivityStatusCode.Ok);
                 }
             }
             catch (Exception e)
             {
                 if (activity is not null && activity.IsAllDataRequested)
                 {
+                    activity.SetStatus(ActivityStatusCode.Error);
+
                     // exception attributes from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/exceptions.md
                     activity.SetTag("exception.type", e.GetType().FullName);
                     activity.SetTag("exception.message", e.Message);
-                    activity.SetTag("exception.stacktrace", e.StackTrace);
+
+                    // Note that "exception.stacktrace" is the full exception detail, not just the StackTrace property. 
+                    // See https://opentelemetry.io/docs/specs/semconv/attributes-registry/exception/
+                    // and https://github.com/open-telemetry/opentelemetry-specification/pull/697#discussion_r453662519
+                    activity.SetTag("exception.stacktrace", e.ToString());
                     activity.SetTag("exception.escaped", true);
-                    activity.SetTag("status", "Error");
                 }
 
                 throw;