Support ProxyGatewayEndpoint from legacy configuration #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test functional Opened #5215 for the initial failure |
ReubenBond
force-pushed
the
fix-legacy-gateway-config
branch
from
0ec9ecd to
48493d3
Compare
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Dec 11, 2018
ReubenBond
added a commit
that referenced
this pull request
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates the
ProxyGatewayEndpointsetting from legacyNodeConfigurationtoEndpointOptions. The silo-to-silo endpoint options are being propagated correctly and don't need to change.GatewayPortis redundant and should not be used ifGatewayEndpointis set, but it shouldn't hurt to explicitly set it anyway.GatewayPortwasn't redundant: it was being used to determine whether or not to start a gateway, etc. I added changes to fix that.