Fix serialization for records which have no properties of their own #8289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/record-serialization
branch
from
de631d1 to
9774b08
Compare
ahydrax
reviewed
Jan 28, 2023
| @@ -1,6 +1,7 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Linq; | |||
| using System.Security.Cryptography.X509Certificates; | |||
There was a problem hiding this comment.
I suppose this was imported accidentally
|
👍 I have verified the fix using our end to end tests and everything looks good. |
|
@ReubenBond thank you for the fix! What are the plans for getting it out? |
|
Building and testing a release at the moment. Hopefully it goes well. I am working through some CI issues |
|
Many thanks for the update! I'll test the fix as soon as the NuGet is
released.
…On Tue, 31 Jan 2023, 00:03 Reuben Bond, ***@***.***> wrote:
Building and testing a release at the moment. Hopefully it goes well. I am
working through some CI issues
—
Reply to this email directly, view it on GitHub
<#8289 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRND7UIRJOFUSPT3HBHN3WVBJETANCNFSM6AAAAAAUJGNJQI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenerateSerializerAttribute.IncludePrimaryConstructorParametersdoc comment says, it defaults to true forrecordtypes - but it should only default totruefor record types. That is fixed now. Also note that non-record types don't (yet) support primary constructors and adding one to an existing type would be a breaking change.Fixes #8286 and #8275
cc @christiansparre & @ahydrax
Microsoft Reviewers: Open in CodeFlow