MySQL migration script: Remove modification for column that no longer exists in Orleans 7

[david-obee]

Problem:

The provided MySQL persistence DB migration script includes a line left over from the Orleans 3.x version, which is no longer applicable to Orleans 7.

As part of the Orleans 7 changes, the OrleansStorage table no longer contains the PayloadJson or PayloadXml columns; it should now only contain the PayloadBinary column.

The line I have removed would try to make a modification on the PayloadJson column, on versions of MySQL 5.7.8 or greater. Assuming you are running the migration on a blank DB, using the CREATE TABLE statement in this script to create your OrleansStorage table, this column will not exist, and this ALTER TABLE line will therefore fail to modify the column.

I suspect it got missed off because the MySQL conditional version syntax makes it look a lot like the line is commented out, when really it just runs on certain versions of MySQL.

I have not found an equivalent issue in any of the other scripts.

Solution:

The solution is just to remove the line, it is no longer necessary.

Tests:

I have run this script and it behaves as expected.

Note: I have not found any associated Github issues that this links to.

[david-obee]

@dotnet-policy-service agree