Don't overstep on IMessage serialization #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteinich
commented
Apr 3, 2023
| if (type == MessageType) | ||
| { | ||
| // Not a concrete implementation, so not directly serializable | ||
| return false; |
There was a problem hiding this comment.
Maybe just returning true here and not changing IsTypeAllowed would make more sense.
ReubenBond
approved these changes
Apr 4, 2023
ReubenBond
reviewed
Apr 4, 2023
| // Not a concrete implementation, but the generic type does give the concrete type | ||
| type = type.GenericTypeArguments[0]; | ||
| } | ||
|
|
||
| if (!MessageParsers.ContainsKey(type.TypeHandle)) | ||
| { | ||
| if (Activator.CreateInstance(type) is not IMessage protobufMessageInstance) |
There was a problem hiding this comment.
It seems that this check could be performed via type.IsAssignableTo(typeof(IMessage)) without invoking the ctor
There was a problem hiding this comment.
This method is really making sure that a message parser can be obtained (and caching that value) as opposed to just verifying the interface. The only other way to obtain the parser is via reflection.
ReubenBond
approved these changes
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProtobufCodecwill try to claim ownership ofIMessageserialization. The result is an exception when trying to access the parser as it isn't a concrete class.This PR will allow the
IMessageinterface serialization to instead be handled by another serializer (AbstractTypeSerializerby default).It also adds a case
IMessage<T>sinceTis the concrete type.Microsoft Reviewers: Open in CodeFlow