Code generator respects scoped usage by language version #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generation will still result in warnings as the scoped usage doesn't match. dotnet/roslyn#63656 provides more details on why that is the case. There is still an issue with the following targets: The |
ReubenBond
approved these changes
Apr 11, 2023
|
Thank you for looking into this, @jsteinich! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scopedkeyword was added in C# 11. Prior to this change, attempting to run the code generator on projects < C# 11 would result in errors. Now, thescopedkeyword is omitted when targeting < C# 11.Microsoft Reviewers: Open in CodeFlow