Improve : throw TypeLoadException on failing to load a type #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riendly exception during deserialization
|
@dotnet-policy-service agree |
ReubenBond
approved these changes
Jun 4, 2023
|
Thank you, @kwemou! These kinds of improvements are very helpful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of a PR 7851 from 3.7.X to orleans 7.
Currently when Orleans fails to load a type, the exception only contains information of missing assembly.
This PR catches exception on Assembly.Load and attach the failed type information in message so it is more helpful.
See an example issue from #8450 and
the old PR from #7851.
I just did a copy pas of @wangjia184 changes.
Microsoft Reviewers: Open in CodeFlow