Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the Locker GitHub action for locking closed/stale issues/PRs #8750

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Dec 1, 2023

This migrates away from the FabricBot implementation of a scheduled search over closed issues and adopts the Locker GitHub action authored by the VS Code team.

The updated fabricbot.json was generated via dotnet/fabricbot-config#83. The workflow file was implemented and tested at https://github.com/dotnet/fabricbot-config/blob/main/.github/workflows/locker.yml.

Since this workflow uses the actions/checkout action, we need to ensure the following GitHub Actions settings are enabled:

  1. Allow enterprise, and select non-enterprise, actions and reusable workflows
  2. Allow actions created by GitHub
Microsoft Reviewers: Open in CodeFlow

@jeffhandley
Copy link
Member Author

FYI @wtgodbe

@ReubenBond
Copy link
Member

@jeffhandley do we need to do anything other than merge this?

@jeffhandley
Copy link
Member Author

Your settings likely already match what's needed since there's an existing workflow that uses the actions/checkout step. Nothing else should be needed for this; it can be merged.

There's only 1 other FabricBot feature in use that needs to be addressed (using 'noActivitySince' in an event filter) before we can apply the full transition away from it to the Policy Service bot.

@ReubenBond ReubenBond merged commit 2e454ae into dotnet:main Dec 2, 2023
19 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/locker-action branch December 2, 2023 19:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants