Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent external codecs from serializing types which are abstract, generated, or from the framework itself #8765

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Dec 12, 2023

This fixes issues where the Newtonsoft.Json codec, for example, will claim responsibility for serializing an invoker, grain reference, or some other type which it should not be serializing. Abstract types are included in this list, since the actual serializer for those are resolved later, when the concrete type is apparent.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond marked this pull request as ready for review December 12, 2023 03:36
@ReubenBond ReubenBond merged commit d6894ae into dotnet:main Dec 13, 2023
19 checks passed
@ReubenBond ReubenBond deleted the fix/custom-codec-type-filters branch December 13, 2023 03:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant