Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating IActivator<T> for abstract types #8777

Merged

Conversation

ledjon-behluli
Copy link
Contributor

@ledjon-behluli ledjon-behluli commented Dec 14, 2023

null

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond changed the title Don't create instance of IActivator for abstract types in code-gen Avoid generating IActivator<T> for abstract types Dec 14, 2023
@ReubenBond ReubenBond merged commit 30d2f57 into dotnet:main Dec 15, 2023
19 checks passed
@ReubenBond
Copy link
Member

This fixes an issue reported by @attilah on Discord: https://discord.com/channels/333727978460676096/1184205613769687070

@ledjon-behluli ledjon-behluli deleted the activator-code-gen-abstract-fix branch December 15, 2023 19:20
@ReubenBond ReubenBond added the Needs: backport PRs which should be backported to a (prior) release branch label Dec 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: backport PRs which should be backported to a (prior) release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants