Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation in IReminderTable #9132

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Update documentation in IReminderTable #9132

merged 2 commits into from
Sep 30, 2024

Conversation

rubenwe
Copy link
Contributor

@rubenwe rubenwe commented Sep 2, 2024

I ran into issues when writing a Firestore-based implementation of Reminders.
In my case, Orleans calls into the ReminderTable implementation with begin: 0 and end: 0.

Based on the existing documentation one could have two interpretations:

  • No entries should be returned; as given the range, no entry can be bigger than 0 and also smaller or equal to 0
  • The entry with hash 0 should be returned

But given this left reminders inoperable, these interpretations don't seem to be correct.

When digging in the contrib repo, I found the handling in the MongoDB ReminderTable to interpret this case as "either bigger than begin or smaller or equal to end". This seems to have the intended effect in my implementation as well.

If this is how it is supposed to work, I think the documentation should be adjusted.

Thanks and have a great day!

Microsoft Reviewers: Open in CodeFlow

Specifically, mentioning the case that begin >= end may occur when timers are read.
@ReubenBond ReubenBond enabled auto-merge (squash) September 30, 2024 17:38
@ReubenBond ReubenBond merged commit c6a9d3a into dotnet:main Sep 30, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants