Update documentation in IReminderTable #9132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues when writing a Firestore-based implementation of Reminders.
In my case, Orleans calls into the ReminderTable implementation with begin: 0 and end: 0.
Based on the existing documentation one could have two interpretations:
But given this left reminders inoperable, these interpretations don't seem to be correct.
When digging in the contrib repo, I found the handling in the MongoDB ReminderTable to interpret this case as "either bigger than begin or smaller or equal to end". This seems to have the intended effect in my implementation as well.
If this is how it is supposed to work, I think the documentation should be adjusted.
Thanks and have a great day!
Microsoft Reviewers: Open in CodeFlow