Skip to content

Fix ZooKeeper CI tests: correct service name and use official Docker image#9699

Merged
ReubenBond merged 3 commits intomainfrom
copilot/fix-b8c256bc-84ff-49d0-9576-638a3c62ddcf
Oct 1, 2025
Merged

Fix ZooKeeper CI tests: correct service name and use official Docker image#9699
ReubenBond merged 3 commits intomainfrom
copilot/fix-b8c256bc-84ff-49d0-9576-638a3c62ddcf

Conversation

Copy link
Contributor

Copilot AI commented Oct 1, 2025

Problem

The ZooKeeper CI tests were failing with the following error:

Error response from daemon: manifest for bitnami/zookeeper:latest not found: manifest unknown: manifest unknown

Additionally, the test configuration had an incorrect service name referencing "consul" instead of "zookeeper".

Solution

This PR fixes two issues in the .github/workflows/ci.yml file for the test-zookeeper job:

  1. Corrected service name: Changed the service name from consul to zookeeper (line 393). This was a copy-paste error from the Consul test configuration.

  2. Updated to official Docker image: Changed the image from bitnami/zookeeper to the official zookeeper:3.9 image. The bitnami :latest tag is no longer available on Docker Hub, causing the manifest not found error. Using the official ZooKeeper image with a specific version tag ensures reproducible builds and follows best practices.

  3. Removed bitnami-specific configuration: The ALLOW_ANONYMOUS_LOGIN environment variable was removed as it's specific to bitnami images and not needed for the official ZooKeeper image, which runs without authentication by default.

Changes

     services:
-      consul:
-        image: bitnami/zookeeper
+      zookeeper:
+        image: zookeeper:3.9
         ports:
           - 2181:2181
-        env:
-          ALLOW_ANONYMOUS_LOGIN: "yes"

These minimal changes align with the configuration patterns used for other services in the workflow file and should resolve the CI test failures for ZooKeeper.

Fixes #9698

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix ZooKeeper CI tests</issue_title>
<issue_description>See: https://productionresultssa3.blob.core.windows.net/actions-results/ac7c45fe-a8b6-42ac-be1e-65b796885f15/workflow-job-run-236fa294-af7a-5bbe-8f53-41b01dc3a536/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-10-01T21%3A57%3A33Z&sig=BmUxiv9Ecmrt79WMY4Rzhx0pRQsCm0RdDrMlshatg0Q%3D&ske=2025-10-02T08%3A19%3A21Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-10-01T20%3A19%3A21Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2025-10-01T21%3A47%3A28Z&sv=2025-11-05

Error response from daemon: manifest for bitnami/zookeeper:latest not found: manifest unknown: manifest unknown
Warning: Docker pull failed with exit code 1, back off 5.498 seconds before retry.

Also note that the stage refers to starting 'consul', but this is for ZooKeeper. Fix that, also.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #9698

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix ZooKeeper CI tests Fix ZooKeeper CI tests: correct service name and use specific image tag Oct 1, 2025
Copilot AI requested a review from ReubenBond October 1, 2025 21:54
@ReubenBond
Copy link
Member

@copilot consider using the official ZooKeeper images: https://hub.docker.com/_/zookeeper

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 1, 2025

@copilot consider using the official ZooKeeper images: https://hub.docker.com/_/zookeeper

Updated to use the official ZooKeeper image (zookeeper:3.9) and removed the bitnami-specific environment variable. Changes in f4acafc.

Copilot AI changed the title Fix ZooKeeper CI tests: correct service name and use specific image tag Fix ZooKeeper CI tests: correct service name and use official Docker image Oct 1, 2025
@ReubenBond ReubenBond marked this pull request as ready for review October 1, 2025 22:28
@ReubenBond ReubenBond merged commit daeddff into main Oct 1, 2025
32 of 36 checks passed
@ReubenBond ReubenBond deleted the copilot/fix-b8c256bc-84ff-49d0-9576-638a3c62ddcf branch October 1, 2025 23:26
ledjon-behluli pushed a commit to ledjon-behluli/orleans that referenced this pull request Oct 26, 2025
…image (dotnet#9699)

* Initial plan

* Fix ZooKeeper CI tests: correct service name and use specific image tag

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Use official ZooKeeper Docker image instead of bitnami

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2025
* retire and purge state machines

* Update src/Orleans.Journaling/StateMachineManager.cs

Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>

* move comments up

* wip

* time-based retirement logic

* last touches

* remove test project

* remove unused usings

* prevent duplicate key error during state machine resurrection

* ensure buffered data is re-applied if machine comes back

* remove hacky assertion in tests

* Update src/Orleans.Journaling/StateMachineManager.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/Orleans.Journaling/StateMachineManager.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix table creation logging to reflect existing tables correctly (#9696)

The `CreateIfNotExistsAsync` method's response will have a 409-statuscode if the table already exists and will always return the `TableItem` if the call is successful.

* Fix ZooKeeper CI tests: correct service name and use official Docker image (#9699)

* Initial plan

* Fix ZooKeeper CI tests: correct service name and use specific image tag

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Use official ZooKeeper Docker image instead of bitnami

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Fix Consul CI tests by using compatible Consul version (#9701)

* Fix Consul key format to comply with allowed characters

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Use custom encoding for Consul keys instead of URL encoding

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Simplify encoding logic to handle both IPv4 and IPv6

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Revert breaking changes and use older Consul version for tests

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Remove explicit ActivityStatusCode.Ok setting to comply with OpenTelemetry specification (#9703)

* Initial plan

* Remove explicit ActivityStatusCode.Ok per OpenTelemetry spec

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* chore(deps): bump dotnet-sdk from 9.0.303 to 9.0.305 (#9677)

Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 9.0.303 to 9.0.305.
- [Release notes](https://github.com/dotnet/sdk/releases)
- [Commits](dotnet/sdk@v9.0.303...v9.0.305)

---
updated-dependencies:
- dependency-name: dotnet-sdk
  dependency-version: 9.0.305
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix race condition in `TransactionInfo.Fork` `PendingCalls` increment (#9702)

* [FIX] Potential NRE in the activation repartitioner (#9713)

fix potentiall NRE in the activation repartioner

* Remove infinite timespan reminder checks (#9715)

* Timeout.InfiniteTimeSpan is not allowed for reminders

* Specifically check for InfiniteTimeSpan to make clear it's usage is not allowed (and to allow for an eventual future change of the InfiniteTimeSpan value)

---------

Co-authored-by: Jerremy Koot <jerremy.koot@gmail.com>

* ResponseCompletionSource: RunContinuationsAsynchronously (#9724)

* chore(deps): bump dotnet-sdk from 9.0.305 to 9.0.306 (#9720)

Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 9.0.305 to 9.0.306.
- [Release notes](https://github.com/dotnet/sdk/releases)
- [Commits](dotnet/sdk@v9.0.305...v9.0.306)

---
updated-dependencies:
- dependency-name: dotnet-sdk
  dependency-version: 9.0.306
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add `BigInteger` codec (#9669)

* StateMachineManager: start work loop during activation (#9725)

* Flag PostgreSQL as asynchronous (#9705)

Changed isSynchronousAdoNetImplementation from true to false for PostgreSQL thanks to updates in Npgsql 8.0.
npgsql/npgsql#1130

* Enable GitHub merge queue (#9727)

Enable merge queue

* Add missing validation for the NATS stream provider (#9668)

Add missing validation for the Nats stream provider

* `ActivationDataActivatorProvider`: run grain constructor on grain scheduler (#9726)

* ActivationDataActivatorProvider: always run grain constructor on ActivationTaskScheduler

* ActivationDataActivatorProvider: always run grain constructor on ActivationTaskScheduler

* Modifying Endpoint to use Pascale Casing as EndPoint for consistency (#9671)

Co-authored-by: Ramzi Mourtada <ramourt@microsoft.com>

* treat retirement tracker as a first-class (internal) machine

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Egil Hansen <egil@assimilated.dk>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bk <bknote71@gmail.com>
Co-authored-by: Da-Teach <da_teach@thehackerwithin.com>
Co-authored-by: Jerremy Koot <jerremy.koot@gmail.com>
Co-authored-by: Gutemberg Ribeiro <gutemberg@outlook.com>
Co-authored-by: Burak Büyükatlı <burak.buyukatli@gmail.com>
Co-authored-by: Ramzi Mourtada <ramzimort@gmail.com>
Co-authored-by: Ramzi Mourtada <ramourt@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ZooKeeper CI tests

2 participants

Comments