Skip to content

Add package README for Orleans.Streaming.NATS#9745

Merged
ReubenBond merged 4 commits intomainfrom
copilot/create-readme-for-nats-package
Nov 5, 2025
Merged

Add package README for Orleans.Streaming.NATS#9745
ReubenBond merged 4 commits intomainfrom
copilot/create-readme-for-nats-package

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

  • Examine existing streaming package READMEs to understand structure and style
  • Review Orleans.Streaming.NATS package code and configuration options
  • Create README.md following the established pattern with:
    • Introduction section
    • Getting Started with NuGet installation
    • Configuration example for silo
    • Configuration example for client
    • Stream producer/consumer example
    • Documentation links
    • Feedback & Contributing section
  • Request code review
  • Address code review feedback (removed unnecessary named parameter)
  • Update csproj to include README.md in NuGet package
Original prompt

On Orleans.Streaming.NATS, Create a package readme for the Orleans.Streaming.NATS package. Look at the other packages to see how their READMEs are typically structured.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Microsoft Reviewers: Open in CodeFlow

Copilot AI and others added 2 commits November 4, 2025 16:38
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Copilot AI changed the title [WIP] Add README for Orleans.Streaming.NATS package Add package README for Orleans.Streaming.NATS Nov 4, 2025
Copilot AI requested a review from ReubenBond November 4, 2025 16:41
@ReubenBond
Copy link
Member

@copilot Do we need to change the csproj so that it includes this README in the nuget package?

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 4, 2025

@copilot Do we need to change the csproj so that it includes this README in the nuget package?

Yes, updated in commit e2fecce. Added <PackageReadmeFile>README.md</PackageReadmeFile> to the PropertyGroup and <None Include="README.md" Pack="true" PackagePath="\" /> to include it in the NuGet package, following the same pattern as other Orleans packages.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • 96bvsblobprodcus338.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • cflvsblobprodcus383.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • ckzvsblobprodcus347.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • dnceng.pkgs.visualstudio.com
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • frdvsblobprodcus327.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • imzvsblobprodcus368.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • jrqvsblobprodcus343.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • kh4vsblobprodcus325.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • lylvsblobprodcus31.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • m6xvsblobprodcus342.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • pdfvsblobprodcus380.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • rcxvsblobprodcus328.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)
  • yluvsblobprodcus367.vsblob.vsassets.io
    • Triggering command: dotnet build src/Orleans.Streaming.NATS/Orleans.Streaming.NATS.csproj --no-incremental (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from ReubenBond November 4, 2025 16:52
@ReubenBond ReubenBond marked this pull request as ready for review November 4, 2025 23:02
@ReubenBond ReubenBond added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 855a18b Nov 5, 2025
60 of 64 checks passed
@ReubenBond ReubenBond deleted the copilot/create-readme-for-nats-package branch November 5, 2025 04:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments