Revert "Deprecate IStartupTask and AddStartupTask with warnings"#9784
Merged
ReubenBond merged 1 commit intomainfrom Nov 18, 2025
Merged
Conversation
This reverts commit 1a1a8c1.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the deprecation warnings for IStartupTask and AddStartupTask methods that were previously introduced in PR #9763. The team decided to defer the deprecation until a better alternative is in place, relying on documentation in the meantime.
- Removes
[Obsolete]attributes fromIStartupTaskinterface and allAddStartupTaskmethod overloads - Removes the pragma warning suppression from test code that was necessary when these APIs were deprecated
- Cleans up an unnecessary
using System;directive that was only needed for theObsoleteattribute
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Orleans.Runtime/Lifecycle/IStartupTask.cs | Removes obsolete attribute from interface and cleans up unused import |
| src/Orleans.Runtime/Hosting/SiloBuilderStartupExtensions.cs | Removes obsolete attributes from all three AddStartupTask method overloads |
| test/Tester/StartupTaskTests.cs | Removes pragma warning suppression that was needed for deprecated APIs |
ReubenBond
deleted the
revert-9763-copilot/deprecate-addstartuptask-and-istartuptask
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9763
We should wait until we have a better alternative in place. For now, documentation is our best bet. We can add docs to these methods and
IStartupTaskitself, too.Microsoft Reviewers: Open in CodeFlow