Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 3 Regressions on 1/31/2023 8:52:14 PM #12501

Closed
performanceautofiler bot opened this issue Feb 7, 2023 · 2 comments
Closed

[Perf] Linux/x64: 3 Regressions on 1/31/2023 8:52:14 PM #12501

performanceautofiler bot opened this issue Feb 7, 2023 · 2 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Feb 7, 2023

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 8b2a92019b2bd24a7c069ef8dfc7d99c28f30d4b
Compare 00c60e41ac459b005338329cd9b5fd5d6652777c
Diff Diff

Regressions in System.IO.Compression.Brotli

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Compress_WithoutState - Duration of single invocation 712.36 μs 888.40 μs 1.25 0.00 False
Compress_WithState - Duration of single invocation 297.85 μs 531.76 μs 1.79 0.05 False
Compress_WithoutState - Duration of single invocation 290.80 μs 506.95 μs 1.74 0.02 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.IO.Compression.Brotli*'

Payloads

Baseline
Compare

Histogram

System.IO.Compression.Brotli.Compress_WithoutState(level: Fastest, file: "alice29.txt")


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 888.4008643939392 > 744.6713163707386.
IsChangePoint: Marked as a change because one of 1/31/2023 6:07:33 PM, 2/7/2023 8:22:47 AM falls between 1/29/2023 5:12:48 PM and 2/7/2023 8:22:47 AM.
IsRegressionStdDev: Marked as regression because -137.05755275895572 (T) = (0 -888512.4815193671) / Math.Sqrt((24036058.739955217 / (23)) + (24392756.35893669 / (36))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (23) + (36) - 2, .025) and -0.2538521448514371 = (708626.200599308 - 888512.4815193671) / 708626.200599308 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Compression.Brotli.Compress_WithState(level: Fastest, file: "TestDocument.pdf")

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 531.7602495833332 > 312.52686645931607.
IsChangePoint: Marked as a change because one of 1/31/2023 6:07:33 PM, 2/7/2023 8:22:47 AM falls between 1/29/2023 5:12:48 PM and 2/7/2023 8:22:47 AM.
IsRegressionStdDev: Marked as regression because -82.58201775048127 (T) = (0 -518644.4603822078) / Math.Sqrt((2565959.3512121355 / (23)) + (252910977.39613888 / (36))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (23) + (36) - 2, .025) and -0.7402583540748838 = (298027.2780577558 - 518644.4603822078) / 298027.2780577558 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Compression.Brotli.Compress_WithoutState(level: Fastest, file: "TestDocument.pdf")

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 506.94654299568975 > 305.06744295138895.
IsChangePoint: Marked as a change because one of 1/31/2023 6:07:33 PM, 2/7/2023 8:22:47 AM falls between 1/29/2023 5:12:48 PM and 2/7/2023 8:22:47 AM.
IsRegressionStdDev: Marked as regression because -142.71821389754493 (T) = (0 -518278.90605386184) / Math.Sqrt((1516435.9074046535 / (23)) + (88635607.96358833 / (36))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (23) + (36) - 2, .025) and -0.7788266312551515 = (291359.98806593136 - 518278.90605386184) / 291359.98806593136 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@kotlarmilos
Copy link
Member

Could be dotnet/runtime#81347

@kotlarmilos
Copy link
Member

Not a regression, but rather a transient improvement.

newplot (3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant